New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that protocols and records are not "empty" #141

Merged

naegelejd merged 1 commit into main from naegelejd/fix-#136

Mar 9, 2024

Contributor

naegelejd commented Mar 7, 2024

Protocol specifications with zero steps and Record specifications with zero fields both produce invalid C++ code.

I fixed by making both required:

Protocols must include the sequence tag and at least one step
Records must include the field tag and at least one field
If a Record has a computedFields tag, it must also include at least one computed field

Closes #136


          Verify that protocols and records are not "empty"

3d65b45

Closes #136

naegelejd requested a review from johnstairs

March 7, 2024 20:36

johnstairs approved these changes

View reviewed changes

naegelejd merged commit 7a0ab26 into main

14 checks passed

naegelejd deleted the naegelejd/fix-#136 branch

March 9, 2024 02:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet